feat: extensibility ums destination changes - #260
Merged
Conversation
|
|
NicoleMGomes
reviewed
Aug 7, 2026
NicoleMGomes
changed the title
Contributor
|
How have you validated these changes? On which agent? |
Contributor
Author
We have an agent https://github.tools.sap/agent-extensibility-test/extensibility-tools-agent; I have started this agent locally and applied the SDK changes to this agent |
NicoleMGomes
reviewed
Aug 9, 2026
NicoleMGomes
reviewed
Aug 9, 2026
NicoleMGomes
previously approved these changes
Aug 10, 2026
NicoleMGomes
previously approved these changes
Aug 10, 2026
NicoleMGomes
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
UMS Destination - New connectivity model
This change is needed because the AppFND team suggested using an existing destination name (sap-managed-runtime-ias-${landscape}) instead of creating a new destination name (sap-managed-runtime-ums-${landscape}) to read the extensions.
Hence, the current code needs to be modified to use the one the AppFND team suggested.
Environment variable support:
Added APPFND_CONHOS_UMS_URL to enable the new IAS-based flow
Dynamic destination resolution:
When APPFND_CONHOS_UMS_URL is set → uses IAS destination (sap-managed-runtime-ias-{landscape})
Otherwise → falls back to legacy UMS destination (sap-managed-runtime-ums-{landscape})
URL resolution logic:
New flow: Base URL from APPFND_CONHOS_UMS_URL environment variable
Legacy flow: Base URL from destination configuration
Both flows: mTLS certificate always from the resolved destination
Related Issue
NA
(Link to the GitHub issue this PR addresses)
Type of Change
Please check the relevant option:
How to Test
Describe how reviewers can test your changes:
Checklist
Before submitting your PR, please review and check the following:
Breaking Changes
There are no breaking changes. We have BCT (Backwards Compatibility) enabled; if the env variable is not found, then it will go with old behaviour
Additional Notes
Tested in the local agent and it worked.